Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NearCacheConfig setEvictionPolicy(String evictionPolicy) #2010

Closed
Danny-Hazelcast opened this issue Mar 13, 2014 · 3 comments

Comments

Projects
None yet
8 participants
@Danny-Hazelcast
Copy link
Member

commented Mar 13, 2014

needs a String argument ?

however

MapConfig setEvictionPolicy(EvictionPolicy evictionPolicy)
wants an enum EvictionPolicy

al the least its inconsistent.

NearCacheConfig has a with default access

static enum EvictionPolicy {
NONE, LRU, LFU
}

@gurbuzali gurbuzali added this to the 3.2+ milestone Mar 13, 2014

@gurbuzali gurbuzali added enhancement and removed defect labels Mar 13, 2014

@Danny-Hazelcast Danny-Hazelcast added defect and removed enhancement labels Mar 19, 2014

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2014

I can fix this one. Shall I remove the method with a String argument or just deprecate it & write overloaded version?

@enesakar enesakar modified the milestones: 3.2.1, 3.++ Apr 11, 2014

@enesakar enesakar added enhancement and removed defect labels Apr 14, 2014

@mdogan mdogan modified the milestones: 3.2.2, 3.2.1 May 6, 2014

@gurbuzali gurbuzali modified the milestones: 3.2.3, 3.2.2 May 26, 2014

@asimarslan asimarslan modified the milestones: 3.3, 3.2.3 May 30, 2014

@noctarius

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2014

Moving to backlog for 3.3+

Anyways I guess deprecate the old method, add documentation to move it to new one and overload the method :) Seems like the correct way to me.

@noctarius noctarius modified the milestones: 3.x Backlog, 3.3 Jul 1, 2014

@Donnerbart

This comment has been minimized.

Copy link
Contributor

commented Sep 22, 2016

Should be fixed by #8854

The new way to configure eviction for Near Caches is the EvictionPolicy of the Near Cache, which uses the enum. This also works now for the on-heap IMap Near Caches. The old methods are of course still there, but deprecated.

@Donnerbart Donnerbart modified the milestones: 3.8, Backlog Sep 22, 2016

@Donnerbart Donnerbart closed this Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.