Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMap.delete() should not call MapLoader.load() #3178

Closed
nurkiewicz opened this issue Aug 6, 2014 · 1 comment

Comments

Projects
None yet
4 participants
@nurkiewicz
Copy link
Contributor

commented Aug 6, 2014

When deleting item that does not exist in a map, IMap calls MapLoader.load(). This is understandable in case of IMap.remove() as it returns removed value (or null). But IMap.delete(), despite returning void, still calls MapLoader.load(). My MapLoader implementation is quite heavyweight, thus I would like to avoid calling it for no particular reason.

The problematic code lies in DefaultRecordStore.java:485. Hazelcast, version 3.2.4.

@ahmetmircik ahmetmircik added this to the 3.3 milestone Aug 6, 2014

@ahmetmircik

This comment has been minimized.

Copy link
Member

commented Aug 6, 2014

Thanks Tomasz for reporting this.
Also valid for 3.3

buremba added a commit to buremba/hazelcast that referenced this issue Aug 11, 2014

@mdogan mdogan modified the milestones: 3.3, 3.2.6 Aug 13, 2014

@enesakar enesakar modified the milestones: 3.2.6, 3.3 Aug 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.