Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputStream in XmlConfigBuilder never closed #390

Closed
jentfoo opened this issue Dec 26, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@jentfoo
Copy link

commented Dec 26, 2012

If you use the constructor which provides an XML file, it creates a new FileInputStream. There is no ability to close this input stream after it is created. I am aware that FileInputStream will close in the finalizer, but still feel this is an issue that warranted to be filed, just in case someone is preventing the XmlConfigBuilder from being GC'ed (not sure why you would, but you should be able to).

pveentjer added a commit to pveentjer/hazelcast that referenced this issue Jun 27, 2013

@pveentjer

This comment has been minimized.

Copy link
Member

commented Jun 27, 2013

... finally got the pr right :)

@ghost ghost assigned pveentjer Jun 27, 2013

@mdogan

This comment has been minimized.

Copy link
Member

commented Jun 27, 2013

Closed by pull request #518

@mdogan mdogan closed this Jun 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.