Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hazelcast-all.jar should build its manifest dynamically #448

Closed
MrEasy opened this issue Mar 20, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@MrEasy
Copy link
Contributor

commented Mar 20, 2013

hazelcast-all.jar has a static MANIFEST.MF located at /hazelcast/hazelcast-all/src/main/resources/META-INF/MANIFEST.MF.
This is hard to maintain and has issues if anything regarding the OSGi dependencies changes. Also there are no versions on the export-packages defined, which exports them implicitely as 0.0.0 - a problem for bundles depending on e.g. (2.5,3.0].

Better would be to build the manifest from the original sources/classes.

The following is a patch on Tag 2.5, which dynamically builds the manifest and gets rid of the problems and the static MANIFEST.MFdescribed above:
https://github.com/seeburger-ag/hazelcast/commit/7d016889c43b08e4be71c7cf13496d7659e2b367.patch

@mdogan

This comment has been minimized.

Copy link
Member

commented Mar 21, 2013

Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.