Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring xml config: the network socket-options attributes should be of type xs:string #4700

Closed
dsukhoroslov opened this issue Mar 2, 2015 · 2 comments

Comments

Projects
None yet
5 participants
@dsukhoroslov
Copy link
Contributor

commented Mar 2, 2015

As of now they're of various simple types:

<xs:complexType name="socket-options">
    <xs:attribute name="tcp-no-delay" type="xs:boolean" use="optional" default="false"/>
    <xs:attribute name="keep-alive" type="xs:boolean" use="optional" default="true"/>
    <xs:attribute name="reuse-address" type="xs:boolean" use="optional" default="true"/>
    <xs:attribute name="linger-seconds" type="xs:unsignedInt" use="optional" default="3"/>
    <xs:attribute name="buffer-size" use="optional" default="32">
        <xs:simpleType>
            <xs:restriction base="xs:unsignedInt">
                <xs:minInclusive value="1"/>
            </xs:restriction>
        </xs:simpleType>
    </xs:attribute>
</xs:complexType>

The types are correct, but prevent us from use of Spring property placeholders. It is not allowed to set the following configuration, for instance:

    <hz:network smart-routing="true">
        <hz:member>${my.schema.members}</hz:member>
        <hz:socket-options buffer-size="${my.buffer.size}"/>
    </hz:network>

because the buffer-size attribute is of type xs:unsignedInt and such config file will not pass initial validation by schema. Is it possible to use xs:string type instead? This change will be backward compartible, shouldn't be any issues with existing configs.

Thanks, Denis.

@dsukhoroslov dsukhoroslov changed the title The network socket-options attributes should be of type xs:string Spring xml config: the network socket-options attributes should be of type xs:string Mar 2, 2015

@gurbuzali gurbuzali added this to the 3.6 milestone Mar 2, 2015

@dsukhoroslov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2015

I can make a PR for this for 3.5, is it ok? The change is quite simple in hazelcast-spring-3.5.xsd only

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2015

fixed by #5590

@mesutcelik mesutcelik closed this Jul 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.