minimal-json with provided scope is not picked up by shade plugin #5543

Closed
mesutcelik opened this Issue Jun 19, 2015 · 3 comments

Projects

None yet

2 participants

@mesutcelik
Contributor

Currently minimal-json config is :

 <dependency>
            <groupId>com.eclipsesource.minimal-json</groupId>
            <artifactId>minimal-json</artifactId>
            <version>0.9.2</version>
            <scope>compile</scope>
  </dependency>

we need to find a way to change the scope to provided while keeping shade plugin work with minimal-json to include the library in hazelcast.jar

@mesutcelik mesutcelik added this to the 3.6 milestone Jun 19, 2015
@jerrinot
Contributor

the shade plugin generates dependency-reduced-pom.xml (or something like this)
isn't this what we should upload to maven central (and all other repositories) instead of our main pom.xml ? as I assume it doesn't contain the shaded libs.

@mesutcelik
Contributor

minimal-json classes are not included inside the hazelcast.jar file. That is the problem.

@jerrinot
Contributor

but if you change the scope of the json library to compile? then the classes will be included in the hazelcast.jar and the dependency won't be visible in the reduced-dependency-pom.xml at the same time?

@mesutcelik mesutcelik added a commit to mesutcelik/hazelcast that referenced this issue Jun 30, 2015
@mesutcelik mesutcelik enabled reduced pom generation,fixes #5543 56722a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment