Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-json with provided scope is not picked up by shade plugin #5543

Closed
mesutcelik opened this issue Jun 19, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@mesutcelik
Copy link
Contributor

commented Jun 19, 2015

Currently minimal-json config is :

 <dependency>
            <groupId>com.eclipsesource.minimal-json</groupId>
            <artifactId>minimal-json</artifactId>
            <version>0.9.2</version>
            <scope>compile</scope>
  </dependency>

we need to find a way to change the scope to provided while keeping shade plugin work with minimal-json to include the library in hazelcast.jar

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2015

the shade plugin generates dependency-reduced-pom.xml (or something like this)
isn't this what we should upload to maven central (and all other repositories) instead of our main pom.xml ? as I assume it doesn't contain the shaded libs.

@mesutcelik

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2015

minimal-json classes are not included inside the hazelcast.jar file. That is the problem.

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2015

but if you change the scope of the json library to compile? then the classes will be included in the hazelcast.jar and the dependency won't be visible in the reduced-dependency-pom.xml at the same time?

mesutcelik added a commit to mesutcelik/hazelcast that referenced this issue Jun 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.