Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide hibernate5 support #5633

Closed
ptahchiev opened this issue Jun 30, 2015 · 16 comments

Comments

@ptahchiev
Copy link

commented Jun 30, 2015

Following this comment:

https://github.com/hazelcast/hazelcast-hibernate4/issues/2#issuecomment-117240433

I would like to ask you to provide hibernate5 support. If I use hibernate5 I get the following exception:

Caused by: java.lang.AbstractMethodError: com.hazelcast.hibernate.HazelcastLocalCacheRegionFactory.start(Lorg/hibernate/boot/spi/SessionFactoryOptions;Ljava/util/Properties;)V
    at org.hibernate.internal.CacheImpl.<init>(CacheImpl.java:48)
    at org.hibernate.engine.spi.CacheInitiator.initiateService(CacheInitiator.java:28)
    at org.hibernate.engine.spi.CacheInitiator.initiateService(CacheInitiator.java:20)
    at org.hibernate.service.internal.SessionFactoryServiceRegistryImpl.initiateService(SessionFactoryServiceRegistryImpl.java:46)
    at org.hibernate.service.internal.AbstractServiceRegistryImpl.createService(AbstractServiceRegistryImpl.java:234)
    at org.hibernate.service.internal.AbstractServiceRegistryImpl.initializeService(AbstractServiceRegistryImpl.java:208)
    at org.hibernate.service.internal.AbstractServiceRegistryImpl.getService(AbstractServiceRegistryImpl.java:189)
    at org.hibernate.internal.SessionFactoryImpl.<init>(SessionFactoryImpl.java:237)
    at org.hibernate.boot.internal.SessionFactoryBuilderImpl.build(SessionFactoryBuilderImpl.java:445)
    at org.hibernate.jpa.boot.internal.EntityManagerFactoryBuilderImpl.build(EntityManagerFactoryBuilderImpl.java:779)
    at org.springframework.orm.jpa.vendor.SpringHibernateJpaPersistenceProvider.createContainerEntityManagerFactory(SpringHibernateJpaPersistenceProvider.java:60)
    at org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:343)
    at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:318)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1633)
    at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1570)
    ... 94 more

@bwzhang2011

This comment has been minimized.

Copy link

commented Aug 25, 2015

@kobalski, any update with such issue ?

@ptahchiev

This comment has been minimized.

Copy link
Author

commented Aug 26, 2015

hibernate5 is already out

@bitvector2

This comment has been minimized.

Copy link

commented Sep 4, 2015

Any news on this issue?

@winweb

This comment has been minimized.

Copy link

commented Sep 9, 2015

any update with this issue ?

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2015

Hi @bitvector2 , @winweb , @bwzhang2011 ,

Unfortunately, Hibernate 5 Support is not in our 3.6 roadmap. However, any kind of contribution is very much appreciated.

We have created a framework for external contributions called Hazelcast Enhanecement Proposals. please feel free to contact us (cc: @noctarius ) if you are interested to contribute to Hibernate 5 Support for Hazelcast.

We are looking forward to hear from you.

@winweb

This comment has been minimized.

Copy link

commented Sep 15, 2015

@mesutcelik Thanks, for your update.

@bturner

This comment has been minimized.

Copy link

commented Nov 18, 2015

@mesutcelik @noctarius

If Hazelcast is interested in contributions for this, I'm happy to add it (I already have it working locally, but I need to do some more exhaustive testing before I open a pull request). I contributed support for 4.2 and 4.3 in #2621 and I was involved with changes to how caching worked in #4110, so I know a bit about the Hibernate bits of the system.

Once I've got my testing done, should I open a pull request? (Note: I understand it likely won't get included in 3.6.)

@noctarius

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2015

Hey @bturner, we're always happy about contribution :) As you figured out it won't be in 3.6 anymore but it is possible to add it to a later patchlevel and 3.7.

I would say this is not big enough for a HEP, is it? Apart from that, as you mentioned, it is almost done. I suggest just open a PR as you said.

@gionn

This comment has been minimized.

Copy link

commented Nov 27, 2015

@bturner if you open a PR I will test it too

@ptahchiev

This comment has been minimized.

Copy link
Author

commented Dec 4, 2015

@bturner any updates here? :)

@bturner

This comment has been minimized.

Copy link

commented Dec 8, 2015

@gionn @ptahchiev Sorry for the delay. I made my changes against a Hazelcast 3.5 branch, so I'm in the process of updating them for 3.6. Hopefully I'll have that done tomorrow.

@bturner

This comment has been minimized.

Copy link

commented Dec 8, 2015

I've opened #7021 with my Hibernate 5 changes.

@LoneRifle

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2016

This issue has been resolved by the above PR and can be considered closed.

@mdogan mdogan modified the milestones: 3.7, Backlog Jun 14, 2016

@mdogan mdogan closed this Jun 14, 2016

@hho

This comment has been minimized.

Copy link

commented Jul 28, 2016

Would be great if 5.x could be added to the Hazelcast manual as well.

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Jul 28, 2016

Thanks for raising this @hho
I believe @Serdaro can can fix this.

@Serdaro

This comment has been minimized.

Copy link
Member

commented Jul 28, 2016

@hho , @mesutcelik , It was already included in the README of https://github.com/hazelcast/hazelcast-hibernate. Please note that Hibernate integration is now a plugin (see https://hazelcast.org/plugins/?type=integration) and the documentation is under its own GitHub repo at https://github.com/hazelcast/hazelcast-hibernate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.