Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Client-based JCA Adapter #5667

Closed
juanavelez opened this issue Jul 7, 2015 · 12 comments

Comments

Projects
None yet
5 participants
@juanavelez
Copy link

commented Jul 7, 2015

Currently if you want to use Container-Managed Transactions with Hazelcast within a JEE Application Server, we need to use the provided JCA Adapter. This JCA Adapter creates a HZ instance.

We would like the option to allow the configuration of the JCA Adapter to be either Server or Client-based.

This would give us the best of two worlds: HZ Clients and XA Resources managed by the container. As it stands if we want to use Transactional Clients we need to manually manage the transactions.

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2015

Hi @juanavelez,
I think it's a logical enhancement. Thank you for reporting this.

@juanavelez

This comment has been minimized.

Copy link
Author

commented Jul 7, 2015

Hi @jerrinot. Thank you for the quick reply. I am not sure what you mean by logical enhancement. From looking at the code, it seems it is "hardcoded" to create Server instances. Would you mind expanding on your answer? Thanks!

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2015

@juanavelez: I'm sorry, I meant a "reasonable" or "sensible" enhancement.
In other words: I like what you are proposing and we should implement it.

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

Hi @juanavelez ,
We have a schedule for 3.6 already and not sure if we can add it but you are always welcome to make such contributions.

just let us know if you need any help.

@juanavelez

This comment has been minimized.

Copy link
Author

commented Jul 13, 2015

Hi @mesutcelik ,

Thanks for the update. I have a couple of questions regarding the contribution and more specifically related to this particular issue. Let me know if I can post these questions directly here or if it'd better to send them to your email address.

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2015

whichever you prefer...
mesut at hazelcast dot com

@kobalski kobalski self-assigned this Jul 23, 2015

@pdudits

This comment has been minimized.

Copy link

commented Sep 22, 2015

Really looking forward for this feature. We are using hazelcast for kind of service registry for our application deployed in glassfish, and we are having race conditions because applications want to register at same time when cluster is building up after startup.

So having client-only JCA adapter would be great approach for us. @juanavelez, is there a branch one could look at and try?

@juanavelez

This comment has been minimized.

Copy link
Author

commented Sep 22, 2015

@pdudits Unfortunately I have not been not given authorization by my US employer to share my changes. Sorry.

@juanavelez

This comment has been minimized.

Copy link
Author

commented Jul 6, 2016

@mesutcelik @jerrinot I have created a pull request in hazelcast-ra for this. Would you guys be able to look at it? Thanks - Juan

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2016

Hi @juanavelez,

many thanks for your effort. We are currently in Feature Freeze phase before 3.7 release, but your PR looks very promising and I'm looking forward to have it merged into Hazelcast 3.8!

@mesutcelik: WDYT?

@jerrinot jerrinot modified the milestones: 3.8, Backlog Jul 6, 2016

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2016

Hi @juanavelez ,

I am on holiday this and next week so i can't check it those days. maybe @emrahkocaman ? However, as your PR has been sent to hazelcast-ra repository, we can release the module right away unless you use a new feature in hazelcast 3.7 master branch.

Thanks for the contribution.

P.S: I see you have already sent the contributor agreement. Welcome to Hazelcast Family 👍

@juanavelez

This comment has been minimized.

Copy link
Author

commented Jul 9, 2016

@mesutcelik Yes, you were the one who told me to put it there (hazelcast/hazelcast-ra#4). And yes, if it can be released right away, I'd appreciate it. I did not use any 3.7-related features.

mesutcelik added a commit to hazelcast/hazelcast-ra that referenced this issue Aug 15, 2016

Merge pull request #5 from juanavelez/issue-5667
Added support for using a Hazelcast Client Instance with the JCA Resource Adapter. Fixes hazelcast/hazelcast#5667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.