Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent and potentially buggy design in BasicCompletableFuture #6080

Closed
tombujok opened this issue Aug 28, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tombujok
Copy link
Contributor

commented Aug 28, 2015

While working on a follow up of the #6062 together with Marko we've noticed some inconsistent and potentially buggy design in BasicCompletableFuture.
A pull request with an Unit Test will document what is meant here.

We've also came up with a couple of improvements that may be done in BasicCompletableFuture and AbstractCompletableFuture as soon as #6062 is merged.

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2015

@tombujok: What you are planning to do with this issue?

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015

@tombujok tombujok referenced this issue Sep 1, 2015

Merged

Fix for #6080 #6106

@tombujok

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2015

@jerrinot Should be fixed through #6106

@tombujok tombujok self-assigned this Sep 1, 2015

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015

@tombujok tombujok added the Team: Core label Sep 2, 2015

@tombujok tombujok added this to the 3.6 milestone Sep 2, 2015

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 2, 2015

tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 2, 2015

gurbuzali added a commit that referenced this issue Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.