Inconsistent and potentially buggy design in BasicCompletableFuture #6080

Closed
tombujok opened this Issue Aug 28, 2015 · 2 comments

Projects

None yet

2 participants

@tombujok
Contributor

While working on a follow up of the #6062 together with Marko we've noticed some inconsistent and potentially buggy design in BasicCompletableFuture.
A pull request with an Unit Test will document what is meant here.

We've also came up with a couple of improvements that may be done in BasicCompletableFuture and AbstractCompletableFuture as soon as #6062 is merged.

@jerrinot
Contributor
jerrinot commented Sep 1, 2015

@tombujok: What you are planning to do with this issue?

@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 f6b80d5
@tombujok tombujok referenced this issue Sep 1, 2015
Merged

Fix for #6080 #6106

@tombujok
Contributor
tombujok commented Sep 1, 2015

@jerrinot Should be fixed through #6106

@tombujok tombujok self-assigned this Sep 1, 2015
@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 3abcdbf
@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 f57be29
@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 1, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 6706c28
@tombujok tombujok added the Team: Core label Sep 2, 2015
@tombujok tombujok added this to the 3.6 milestone Sep 2, 2015
@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 2, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 3662a23
@tombujok tombujok added a commit to tombujok/hazelcast that referenced this issue Sep 2, 2015
@tombujok tombujok Follow up on #6020 #6062 and #6081; Fixes #6080 9e20ebf
@gurbuzali gurbuzali closed this in #6106 Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment