Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOBalancer has a memory leak #6199

Closed
eminn opened this issue Sep 14, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@eminn
Copy link
Collaborator

commented Sep 14, 2015

IOBalancer keeps references of all the socket reader/writers but when destroying the connection they release the references for only the ones which has endpoints.

It could be seen from the image below that socket writers consume %77 of the total memory after all the connections to hazelcast are destroyed.

screen shot 2015-09-14 at 10 55 32 am

@eminn eminn added this to the 3.6 milestone Sep 14, 2015

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2015

good one!

@serkan-ozal

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2015

good finding 👍

eminn added a commit to eminn/hazelcast that referenced this issue Sep 14, 2015

If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes hazelcast#6199

@eminn eminn closed this in 2100148 Sep 14, 2015

Donnerbart added a commit to Donnerbart/hazelcast that referenced this issue Sep 17, 2015

If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes hazelcast#6199
@mahileeb

This comment has been minimized.

Copy link

commented Feb 25, 2016

we're seeing another memory leak in IOBalancer in v3.6 - Socket readers/writers are building up in LoadTracker.lastEventCounter. They are getting added to the ItemCounter by updateNewWorkingImbalance but the handler is not removed from the ItemCounter when removeHandler is called.

Can we re-open this issue or should I open a new one?

@eminn

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 1, 2016

I am working on a reproducer for your case.

@eminn

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 2, 2016

Thanks @mahileeb issue has been fixed and the fix will be available on 3.6.2 and 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.