IOBalancer has a memory leak #6199

Closed
eminn opened this Issue Sep 14, 2015 · 5 comments

Projects

None yet

4 participants

@eminn
Collaborator
eminn commented Sep 14, 2015

IOBalancer keeps references of all the socket reader/writers but when destroying the connection they release the references for only the ones which has endpoints.

It could be seen from the image below that socket writers consume %77 of the total memory after all the connections to hazelcast are destroyed.

screen shot 2015-09-14 at 10 55 32 am

@eminn eminn added this to the 3.6 milestone Sep 14, 2015
@jerrinot
Contributor

good one!

@eminn eminn added a commit to eminn/hazelcast that referenced this issue Sep 14, 2015
@eminn eminn If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes #6199
2100148
@serkan-ozal
Contributor

good finding 👍

@eminn eminn added a commit to eminn/hazelcast that referenced this issue Sep 14, 2015
@eminn eminn If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes #6199
6a15980
@eminn eminn added a commit that closed this issue Sep 14, 2015
@eminn eminn If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes #6199
2100148
@eminn eminn closed this in 2100148 Sep 14, 2015
@Donnerbart Donnerbart added a commit to Donnerbart/hazelcast that referenced this issue Sep 17, 2015
@eminn @Donnerbart eminn + Donnerbart If the connection is destroyed and removed from active connections, i…
…t should be removed from iobalancer regardless of connection endpoint. Fixes #6199
d2774d9
@mahileeb

we're seeing another memory leak in IOBalancer in v3.6 - Socket readers/writers are building up in LoadTracker.lastEventCounter. They are getting added to the ItemCounter by updateNewWorkingImbalance but the handler is not removed from the ItemCounter when removeHandler is called.

Can we re-open this issue or should I open a new one?

@eminn
Collaborator
eminn commented Mar 1, 2016

I am working on a reproducer for your case.

@eminn eminn reopened this Mar 1, 2016
@eminn eminn closed this Mar 2, 2016
@eminn
Collaborator
eminn commented Mar 2, 2016

Thanks @mahileeb issue has been fixed and the fix will be available on 3.6.2 and 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment