Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom credintials class is not de-serialized on the server side #6615

Closed
dsukhoroslov opened this issue Oct 30, 2015 · 1 comment

Comments

Projects
None yet
5 participants
@dsukhoroslov
Copy link
Contributor

commented Oct 30, 2015

HZ 3.6-EA.
I use custom cridentials class which inherits from UsernamePasswordCredential class. I need to provide some additional auth data from client to server. Till version 3.5.3 it works fine: the custom credentials class was deserialized and used on the server side. In 3.6-EA the standard UsernamePasswordCredential class deserialized instead. Auth message created on the server side is AuthenticationMessageTask, but it must be AuthenticationCustomCredentialsMessageTask, I believe.

Please have a look.
Thanks, Denis.

@gurbuzali gurbuzali added this to the 3.6 milestone Oct 31, 2015

@sancar sancar self-assigned this Oct 31, 2015

@cangencer cangencer assigned cangencer and unassigned sancar Nov 3, 2015

cangencer added a commit to cangencer/hazelcast that referenced this issue Nov 4, 2015

Stricter type check when deciding if ClientAuthenticationCustomCodec …
…should be used or not during authentication

Fixes the issue when the custom credentials given extends UsernamePasswordCredentials. Added tests for
both new and legacy client, however the issue only effects the new client. Fixes issue hazelcast#6615

cangencer added a commit to cangencer/hazelcast that referenced this issue Nov 4, 2015

Stricter type check when deciding if ClientAuthenticationCustomCodec …
…should be used for authentication

Fixes the issue when the custom credentials given extends UsernamePasswordCredentials. Added tests for
both new and legacy client, however the issue only effects the new client. Fixes issue hazelcast#6615
@enesakar

This comment has been minimized.

Copy link
Member

commented Nov 12, 2015

fixed by #6644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.