Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badly named method in Discovery SPI configuration #6911

Closed
jerrinot opened this issue Nov 30, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@jerrinot
Copy link
Contributor

commented Nov 30, 2015

public void addDiscoveryProviderConfig(DiscoveryStrategyConfig discoveryStrategyConfig) {

@noctarius has confirmed it's a left-over. it should be addDiscoveryStrategyConfig().

Given it has never been released as a final I it's ok just to rename it.

@jerrinot jerrinot added this to the 3.6 milestone Nov 30, 2015

@jerrinot jerrinot self-assigned this Nov 30, 2015

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Nov 30, 2015

Misleading method named fixed.
It's a left-over from old Discovery SPI implementation. I am not deprecating the old method as it has never been released as a Final.
Fixing hazelcast#6911
@jerrinot

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2015

fixed by #6912

@jerrinot jerrinot closed this Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.