Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add map.partition-strategy configuration into Spring config #7363

Closed
dsukhoroslov opened this issue Jan 19, 2016 · 8 comments

Comments

Projects
None yet
6 participants
@dsukhoroslov
Copy link
Contributor

commented Jan 19, 2016

It is possible to specify partition-strategy in HZ confug, but not in Spring config. Please add it. Not implemented in any HZ versions, afaik.
Also, would be nice to be able to specify not only class implementing partoition strategy, but an implementing instance as well.

Thanks, Denis

@dsukhoroslov dsukhoroslov changed the title add map.partition-strategy configuration into string config add map.partition-strategy configuration into Spring config Jan 19, 2016

@dsukhoroslov

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2016

Hi @jerrinot

I can implement it for 3.7. As well as other configuration parameters missed in spring-integration.

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2016

@dsukhoroslov: That would be awesome!
@mesutcelik: I guess you will not complain about this? ;-)

@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2016

we are looking forward to your PR @dsukhoroslov :)

@dsukhoroslov

This comment has been minimized.

Copy link
Contributor Author

commented Feb 10, 2016

ok, started to work on it in scope of this issue and #6567. If you're aware of any other configuration elements missed in Spring - please tell me, I'll try to handle them too.

@elgamilg

This comment has been minimized.

Copy link

commented Mar 3, 2016

@dsukhoroslov: I have a similar issue and noticed the following properties are also missing from the Spring config in 3.6.1:

  • In hz:multicast there is no way to specify "trusted-interfaces"
  • In hz:network there is no way to specify "port-count"
  • In hz:aws there is no way to specify "iamRole"
@mesutcelik

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2016

Hi @dsukhoroslov ,
Have you had some time to work on this?

@elgamilg has pointed some more properties missing in the current implementation. It would be great if you include them as well.

@mesutcelik mesutcelik added this to the 3.6.2 milestone Mar 11, 2016

@dsukhoroslov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2016

Hi @mesutcelik,

Yes, I started and did all changes in schema, but had no time to finish it in java. Hopefully will do next week. Sure, I'll add the properties mentioned by @elgamilg.
I'm still waiting when my PR #7546 will be merged. It is not comfortable to work with more then one forks at the same time.

@dsukhoroslov

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2016

solved by #8202

@emrahkocaman emrahkocaman modified the milestones: 3.7, 3.6.3 May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.