Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback order and content of InitialMembershipEvent #7430

Closed
nilskp opened this issue Jan 29, 2016 · 0 comments

Comments

Projects
None yet
4 participants
@nilskp
Copy link
Contributor

commented Jan 29, 2016

For clients, InitialMembershipListener.init is called after all MembershipListener.memberAdded, which contradicts the docs:

The InitializingMembershipListener is a MembershipListener that first receives a InitialMembershipEvent when it is registered so it immediately knows which members are available. After that event has been received, it will receive the normal MembershipEvents

For members, InitialMembershipListener.init is called immediately, but getMembers only contains itself, which also seems to contradict the intent described in the docs.

@jerrinot jerrinot added this to the 3.7 milestone Jan 29, 2016

@sancar sancar self-assigned this Feb 17, 2016

sancar added a commit to sancar/hazelcast that referenced this issue Feb 18, 2016

Fix fired events when initialMembersipListener is used on client
When initial membership event added before client is started,
it was firing individual ADDED events for current memberlist,
along with InitialMembershipEvent. Only latter is preserved,
other events are removed.

Related tests are added.
Membershiplistener related tests in ClientRegressionWithMockNetworkTest
are moved to MembershipListenerTest.

fixes hazelcast#7430

sancar added a commit to sancar/hazelcast that referenced this issue Feb 18, 2016

Fix fired events when initialMembersipListener is used on client
When initial membership event added before client is started,
it was firing individual ADDED events for current memberlist,
along with InitialMembershipEvent. Only latter is preserved,
other events are removed.

Related tests are added.
Membershiplistener related tests in ClientRegressionWithMockNetworkTest
are moved to MembershipListenerTest.

fixes hazelcast#7430
backport of hazelcast#7543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.