Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Get with 100 keys fails #8535

Closed
wolframite opened this issue Jul 15, 2016 · 6 comments

Comments

Projects
None yet
7 participants
@wolframite
Copy link

commented Jul 15, 2016

A real memcached instance can fetch more than 150 keys at the same time, hazelcast fails at that because the capacity in the com.hazelcast.nio.ascii.TextReadHandler is set too low (currently 500).

If this is raised to e.g. 5000, it's possible to fetch 100 keys with a key length of 32 byte. I wrote a unit test, to reproduce the problem: https://github.com/zalora/hazelcast/commit/1c2d4fe14930782d33647cffdd2a0f575b36022c

Is it ok, if I raise the buffer size to 5000 and create a pull request for it? I already signed the contributor agreement form: https://hazelcast.atlassian.net/wiki/display/COM/Hazelcast+Contributor+Agreement

@noctarius

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2016

Hey Wolfram,

Glad to see you're still working with Hazelcast. Unfortunately you still have to use the memcached API since the PHP is not ready ;-)

As long as you signed the CLA already you're good to send a PR including the fix and a unittest to proof the fix.

@wolframite

This comment has been minimized.

Copy link
Author

commented Jul 15, 2016

Oh, I'm not only working with Hazelcast, we're currently rolling it out at work as a replacement for Memcached. That's why I want to make Hazelcast more Memcached compatible. Unfortunately the PHP client has to wait until we're done with the rollout.

I have some more changes in the pipeline, but I'd like to discuss them first and ask if there are better ways to achieve the goal. I'll send the PR and will mention the issue here...

@LoneRifle

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2016

@lunatic666 I will be happy to help out with implementing the changes you may be proposing. @noctarius should be able to provide you with my contact details, or get hold of me on gitter.

@noctarius

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2016

Love the community spirit :) Please guys, go ahead!

@wolframite

This comment has been minimized.

Copy link
Author

commented Jul 21, 2016

@LoneRifle Thanks for the offer! I'll catch up with you on Gitter

@mdogan mdogan added this to the 3.7.1 milestone Jul 29, 2016

@jerrinot jerrinot modified the milestones: 3.7.1, 3.7.2 Aug 29, 2016

@degerhz degerhz modified the milestones: 3.8, 3.7.2 Sep 23, 2016

@sancar

This comment has been minimized.

Copy link
Member

commented Dec 2, 2016

merged to #9355

@sancar sancar closed this Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.