Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: connection type in name always NONE #8540

Closed
pveentjer opened this issue Jul 18, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@pveentjer
Copy link
Member

commented Jul 18, 2016

When the connection is made, the connection type is not known yet. But the connection type is used in the metrics id, and the metrics id is used as soon as the connection is made. So it defaults to NONE in the 'getMetricsId' function.

And that is why you see for all connections:

   tcp.connection[NONE#/10.144.232.211:60318->/10.231.187.181:5701].in.ioThreadId=1

No matter if something a client thread or not.

Probably it would be better to add a probe 'connection type' (integer value) and remove the connection type from the TcpIpConnection.getMetricsId function

This is a minor issue. Just a small debug improvement.

@pveentjer pveentjer added this to the 3.7 milestone Jul 18, 2016

pveentjer added a commit to pveentjer/hazelcast that referenced this issue Jul 18, 2016

Added connectionType probe
Added the connection type probe to TcpIpConnection

fixes hazelcast#8540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.