Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client tasks should be bounced back when a member has not completed start yet #8715

Closed
jerrinot opened this issue Aug 15, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jerrinot
Copy link
Contributor

commented Aug 15, 2016

Clients tasks should not be processed until a member start is completed. "start completed" means (among other things) that loading for HotRestart was completed.

Serving client requests before loading is completed lead to consistency issues. For example:

  • a member with HotRestart was just started
  • entry is stored in the persistence store, but it is not loaded yet into RAMStore -> the entry does not exist for a client.  
  • loading is finished
  • the entry is created "out-of-thin-air" (for the client)

See: NodeExtension.isStartCompleted()

Some tasks still have to be processed even when member start is not completed: e.g. the Heartbeat task.

@jerrinot jerrinot added this to the 3.8 milestone Aug 15, 2016

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 15, 2016

Fixes issue hazelcast#8715
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 15, 2016

Fixes issue hazelcast#8715
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 15, 2016

Fixes issue hazelcast#8715
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 15, 2016

Fixes issue hazelcast#8715
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 16, 2016

Fixes issue hazelcast#8715
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 18, 2016

Fixes issue hazelcast#8715
    The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit to ihsandemir/hazelcast that referenced this issue Aug 18, 2016

Fixes issue hazelcast#8715
    The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit that referenced this issue Aug 18, 2016

Fixes issue #8715 (#8722)
The task checks if the node extension start is finished before processing the message.

ihsandemir added a commit that referenced this issue Aug 18, 2016

Fixes issue #8715 (#8725)
The task checks if the node extension start is finished before processing the message.
@ihsandemir

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

The PRs are merged. Closing the issue.

@ihsandemir ihsandemir closed this Aug 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.