Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring xml config: the smart routing attribute defaults to false while the docs say its enabled #8746

Closed
fmacicasan opened this issue Aug 18, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@fmacicasan
Copy link

commented Aug 18, 2016

Hello,

The smart routing attribute defaults to false while the documentation (and the ClientNetworkConfig) defaults to true.

Is there any reasoning behind this choice?

We relied on the "docs default" and now we are experiencing "Wait for owner connection is timed out" errors (which shouldn't be triggered if smart routing is enabled).

<xs:attribute name="smart-routing" use="optional" type="xs:boolean" default="false"/>

Note: We are using hazelcast 3.3.3, but the spring config default is the same in the latest release.

Thanks for the info!
Florin.

@jerrinot jerrinot added this to the 3.8 milestone Aug 18, 2016

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2016

@fmacicasan: we good catch. I think it's an error, many thanks thanks for reporting!

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Aug 18, 2016

Fix wrong client defaults when configured via Spring
Fix hazelcast#8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Aug 19, 2016

Fix wrong client defaults when configured via Spring
Fix hazelcast#8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Aug 19, 2016

Fix wrong client defaults when configured via Spring
Fix hazelcast#8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Aug 19, 2016

Fix wrong client defaults when configured via Spring
Fix hazelcast#8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

jerrinot added a commit to jerrinot/hazelcast that referenced this issue Aug 22, 2016

Fix wrong client defaults when configured via Spring
Fix hazelcast#8746
It would be great to  just use equals() on the config objects,
however a lot of our *Config(s) do not override equals()/hashcode()
and moreover the config objects are mutated in some cases - e.g.
  https://github.com/hazelcast/hazelcast/blob/eef987b9920f3f7b4c506e433b0d067cab9ba93c/hazelcast-client/src/main/java/com/hazelcast/client/config/ClientNetworkConfig.java#L207-L207

(cherry picked from commit 939c25c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.