Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BlockingOperation heartbeat problem #8979

Conversation

pveentjer
Copy link
Contributor

@pveentjer pveentjer commented Sep 26, 2016

The problem is that the WaitingOperation; the container around the BlockingOperation; is
asked for callid/calleraddress. But this container object doesn't have any sensible
information, so the heartbeat is not constructed correctly for a blocked Operation.

The problem is that the ParkedOperation; the container around the BlockingOperation; is
asked for callid/calleraddress. But this container object doesn't have any sensible
information, so the heartbeat is not constructed correctly for a blocked Operation.
for (WaitingOperation op : queue) {
liveOperations.add(op.getCallerAddress(), op.getCallId());
for (WaitingOperation waitingOperation : queue) {
// we need to read out the data from the BlockedOperation; not from the ParkerOperation-container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tiny one - the ParkerOperation-container. has a different name in the maintanance branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me do that through a direct push if there are not other comments.

@devOpsHazelcast
Copy link
Collaborator

Test PASSed.

Copy link
Contributor

@Donnerbart Donnerbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #8977

@Donnerbart Donnerbart added this to the 3.7.2 milestone Sep 26, 2016
@pveentjer pveentjer merged commit 83cdf32 into hazelcast:3.7.2 Sep 26, 2016
@pveentjer pveentjer deleted the fix/3.7.2/BlockingOperations-heartbeat-failure branch September 26, 2016 09:02
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants