Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast not handling XML config attribute for DurableExecutorService. #9078

Closed
rscnt opened this issue Oct 10, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@rscnt
Copy link

commented Oct 10, 2016

Hazelcast version: 3.7.2
Cluster size: 1

Java

java version "1.8.0_91" 
Java(TM) SE Runtime Environment (build 1.8.0_91-b14) 
Java HotSpot(TM) 64-Bit Server VM (build 25.91-b14, mixed mode) 

OS: Linux 4.2.3-300.fc23.x86_64

hazelcast.xml: hazelcast.xml

The configuration is written as it's indicated in the documentation, however it seems that hazelcast is ignoring/not handling, the <durable-executor-service /> nodes.

These are the only things I noticed peeking a little in the code that's on master:

The hazelcast-full-example.xml is using <executor-service /> for the <durable-executor-service /> example.

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/resources/hazelcast-full-example.xml#L429

And the ConfigXMLGenerator includes a <durable-executor-service /> node:

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/config/ConfigXmlGenerator.java#L123

But if I'm understand correctly, since the <durable-executor-service /> node is not present on the examples the test:

private static void testConfig2Xml2Config(String fileName) {

Does not check if it's "valid" or not.

XMLConfigBuilder#handleXMLNode is not "handling" the <durable-executor-service / >:

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/config/XmlConfigBuilder.java#L275

And the node is not declared in XMLElements enum:

https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/config/XmlElements.java#L19

I can't write an unit test for it right now, also it's probably that you are all aware of this issue, but I couldn't find a reference for it anywhere.

@gurbuzali gurbuzali added this to the 3.8 milestone Oct 10, 2016

@gurbuzali gurbuzali self-assigned this Oct 10, 2016

@jerrinot jerrinot assigned mmedenjak and unassigned gurbuzali Dec 12, 2016

@mmedenjak

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2016

Hi @rscnt , great analysis, you are right about everything. All of this has been fixed, including the spring configuration and will be included in the next release.
Thanks for the effort!

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2016

closing it's already fixed in 3.8
@rscnt: once more thanks for this great report!

@jerrinot jerrinot closed this Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.