Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAll not updating localMapStats (hz 3.7.3) #9373

Closed
fredang opened this issue Dec 5, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@fredang
Copy link
Contributor

commented Dec 5, 2016

Hi,

I did a small test where I call Get/GetAll/Put/PutAll multiple times on a distributed map and then output the local map stats.
The Get/Put/PutAll are showing properly in the local map stats.
However this is not the case for GetAll (seems to be excluded from the stats).

To reproduce the issue:

        HazelcastInstance instance = Hazelcast.newHazelcastInstance();

        IMap<String, Integer> map = instance.getMap("test");
        for(int i = 0 ; i < 100 ; i++) {
            Map<String, Integer> putMap = new HashMap<>();
            String key1 = "key1-" + i;
            String key2 = "key2-" + i;
            putMap.put("key1-" + i, i);
            putMap.put("key2-" + i , i);
            map.putAll(putMap);


            Set<String> keys = new HashSet<>();
            keys.add(key1);
            keys.add(key2);
            map.getAll(keys);
        }
        System.out.println(map.getLocalMapStats());

It outputs the following stats

LocalMapStatsImpl{lastAccessTime=1480968873116, lastUpdateTime=1480968873116, hits=200, 
numberOfOtherOperations=0, numberOfEvents=0, getCount=0, putCount=200, removeCount=0,
totalGetLatencies=0, totalPutLatencies=120, totalRemoveLatencies=0, ownedEntryCount=200,
backupEntryCount=0, backupCount=1, ownedEntryMemoryCost=31780, backupEntryMemoryCost=0,
creationTime=1480968872891, lockedEntryCount=0, dirtyEntryCount=0, heapCost=31780}

@jerrinot jerrinot added this to the 3.8 milestone Dec 5, 2016

fredang pushed a commit to fredang/hazelcast that referenced this issue Dec 6, 2016

jerrinot added a commit that referenced this issue Dec 8, 2016

Merge pull request #9387 from fredang/bug-9363
Small fix for #9373 (GetAll not updating localMapStats)
@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2016

fixed by #9387

@jerrinot jerrinot closed this Dec 13, 2016

@jerrinot

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2016

👏 for @fredang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.