Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hazelcast xml network tag #945

Closed
ctamisier opened this issue Oct 4, 2013 · 1 comment

Comments

Projects
None yet
5 participants
@ctamisier
Copy link

commented Oct 4, 2013

Hi,

This is a based on discussion here:
https://groups.google.com/forum/#!topic/hazelcast/4xgZNtZKWnw

Default configuration are different between XML config or programmatic config.
The thing is if I want to configure hazelcast (with xml) and just change the group section, i have to set enabled=true for multicast tag.

the XSD specify default="true" and Java specify DEFAULT_ENABLED = true.
But in XML: config.getNetworkConfig().getJoin().getMulticastConfig().setEnabled(false);

So should it be .setEnabled(true) ?

@pveentjer

This comment has been minimized.

Copy link
Member

commented Oct 4, 2013

I'm also in favor of making the behavior for the XML exactly the same as the programmatic configuration, or otherwise update the XSD to indicate that multicast is not enabled by default.

@mdogan mdogan added the PENDING label May 28, 2014

@ajermakovics ajermakovics added Team: Core and removed Team: Core labels Oct 14, 2014

@enesakar enesakar removed the PENDING label Nov 2, 2015

pveentjer added a commit to pveentjer/hazelcast that referenced this issue May 7, 2016

fix hazelcast#945 xml multicast disabled by default
This is a inconsistency with the xsd; which clearly states that xml is enabled by default.
It also is an inconsistency with the programmatic api, where multicast is enabled by default.

This fix resolves these inconsistencies. However it could be that people that only configure
tcp and have not explicitly disabled multicast, since it was disabled by default, now get an
error because multicast needs to be explicitly disabled (you can have multiple join mechanisms active).

@pveentjer pveentjer added this to the 3.7 milestone May 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.