Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked existence of key in-memory before proceed #11251

Conversation

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Aug 28, 2017

needs ee counterpart

@ahmetmircik ahmetmircik added this to the 3.8.5 milestone Aug 28, 2017
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.8.5/NPEOnLoadAll branch from 46e8dba to 8a1f44e Aug 28, 2017
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.8.5/NPEOnLoadAll branch from 8a1f44e to f6f8569 Aug 28, 2017
@@ -735,6 +735,11 @@ protected void addMapEntrySet(Map<Object, Object> entries, MapEntries mapEntries
}

@Override
public boolean existInMemory(Data key) {
return storage.containsKey(key);

This comment has been minimized.

@tombujok

tombujok Aug 28, 2017
Contributor

@ahmetmircik Good catch with this checkIfLoaded, I was also in doubt that it is needed here ;)

@tombujok tombujok closed this Aug 28, 2017
@tombujok
Copy link
Contributor

@tombujok tombujok commented Aug 28, 2017

Thx Ahmet. Loos good. I cherry-picked your commit here: #11253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.