Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cache] Updates for JCache 1.1 compatibility #12014

Merged
merged 6 commits into from Jan 8, 2018

Conversation

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Dec 17, 2017

JCache 1.1 compatibility fixes:

  • Cache config key value type checks are not enforced in CacheManager.getCache(name)
  • CacheManager.getCacheNames throws exception when CacheManager is already closed
  • Cache.putIfAbsent statistics effects properly applied
  • Minor cleanup & fix to start a named HazelcastInstance when the default CachingProvider is in use

This PR will not turn green until javax.cache:cache-tests:1.1.0 becomes available on maven central.

@vbekiaris vbekiaris added this to the 3.10 milestone Dec 17, 2017
@vbekiaris vbekiaris self-assigned this Dec 17, 2017
Copy link
Contributor

@Donnerbart Donnerbart left a comment

Was very nice to review while reading the TDD. Good job!

vbekiaris added 4 commits Oct 20, 2017
Align name of method with CacheProxy.ensureOpen
In order to reuse the default HazelcastInstance when the default config
has no instance name set, a default name is set. An option to leave the
instance unnamed is also provided.
This fix allows the JCache TCK to execute without starting multiple
Hazelcast instances.
@vbekiaris
Copy link
Contributor Author

@vbekiaris vbekiaris commented Dec 21, 2017

run-lab-run

@vbekiaris vbekiaris force-pushed the vbekiaris:fixes/3.10/jcache-1.1 branch from 23bf15d to 8393fbb Dec 22, 2017
@kwart
kwart approved these changes Jan 5, 2018
@vbekiaris vbekiaris merged commit 3f48cc1 into hazelcast:master Jan 8, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@vbekiaris vbekiaris deleted the vbekiaris:fixes/3.10/jcache-1.1 branch May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.