[BACKPORT] Forbid shutting down member via console on Management Center #12328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pveentjer
added
Team: Client
Team: Core
[OLD]Team: Integration
and removed
[OLD]Team: Integration
Team: Client
Team: Core
labels
|
Sorry for changing the tags. I thought I was modifying the PR I just made. |
Shutting down members individually or the cluster entirely is possible via Management Center screens. These screens ask for the cluster name and the password. However, the console tab on Management Center doesn't ask for any additional credentials for stopping a member, so we don't allow these operations via console. A bug in our implementation allowed upper case, mixed case and composite commands to pass through. Executing "shutdown" was allowed as well. This commit makes sure that a console command coming from Management Center will not be able to shut down a member. (cherry picked from commit 4aab7db) Backport "Prevent division by zero for fast repeat operations"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutting down members individually or the cluster entirely is possible
via Management Center screens. These screens ask for the cluster name
and the password. However, the console tab on Management Center doesn't
ask for any additional credentials for stopping a member, so we don't
allow these operations via console. A bug in our implementation allowed
upper case, mixed case and composite commands to pass through. Executing
"shutdown" was allowed as well. This commit makes sure that a console
command coming from Management Center will not be able to shut down
a member.
(cherry picked from commit 4aab7db)