Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Forbid shutting down member via console on Management Center #12328

Merged

Conversation

@emre-aydin
Copy link
Member

@emre-aydin emre-aydin commented Feb 13, 2018

Shutting down members individually or the cluster entirely is possible
via Management Center screens. These screens ask for the cluster name
and the password. However, the console tab on Management Center doesn't
ask for any additional credentials for stopping a member, so we don't
allow these operations via console. A bug in our implementation allowed
upper case, mixed case and composite commands to pass through. Executing
"shutdown" was allowed as well. This commit makes sure that a console
command coming from Management Center will not be able to shut down
a member.

(cherry picked from commit 4aab7db)

@pveentjer
Copy link
Member

@pveentjer pveentjer commented Feb 13, 2018

Sorry for changing the tags. I thought I was modifying the PR I just made.

Shutting down members individually or the cluster entirely is possible
via Management Center screens. These screens ask for the cluster name
and the password. However, the console tab on Management Center doesn't
ask for any additional credentials for stopping a member, so we don't
allow these operations via console. A bug in our implementation allowed
upper case, mixed case and composite commands to pass through. Executing
 "shutdown" was allowed as well. This commit makes sure that a console
 command coming from Management Center will not be able to shut down
 a member.

(cherry picked from commit 4aab7db)

Backport "Prevent division by zero for fast repeat operations"
@emre-aydin emre-aydin force-pushed the emre-aydin:backport-console-fix branch from 5da5e53 to 4917a79 Feb 13, 2018
@emre-aydin
Copy link
Member Author

@emre-aydin emre-aydin commented Feb 13, 2018

Already reviewed here and here

@emre-aydin emre-aydin merged commit 8654b43 into hazelcast:maintenance-3.x Feb 13, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@emre-aydin emre-aydin deleted the emre-aydin:backport-console-fix branch Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.