Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Revising authentication timeout logic to prevent slow shutdown #12362

Conversation

@sancar
Copy link
Member

@sancar sancar commented Feb 16, 2018

For authentication timeout, there was a scheduled task introduced
recently:
Pr
Line
127eb14#diff-6b832face5ab9f5e23687eaeb478627eR631

Client needs to wait all scheduled tasks to finish before shutdown.
Authentication timeout was scheduled for 5 seconds(default connection timeout)

Hard timeout is introduced in client invocation to solve same
problem. CleanResources task is now responsible to check that timeout.
This new timeout mechanism is only used by authentication for now.

@sancar sancar added this to the 3.9.4 milestone Feb 16, 2018
@sancar sancar self-assigned this Feb 16, 2018
For authentication timeout, there was a scheduled task introduced
recently:
Pr
Line
127eb14#diff-6b832face5ab9f5e23687eaeb478627eR631

Client needs to wait all scheduled tasks to finish before shutdown.
Authentication timeout was scheduled for 5 seconds(default connection timeout)

Hard timeout is introduced in client invocation to solve same
problem. CleanResources task is now responsible to check that timeout.
This new timeout mechanism is only used by authentication for now.
@sancar sancar force-pushed the sancar:fix/authenticationTimeout/maint3.x branch from 68a4dfe to 6838b30 Feb 16, 2018
@sancar sancar changed the title Revising authentication timeout logic to prevent slow shutdown [WIP]Revising authentication timeout logic to prevent slow shutdown Feb 20, 2018
@sancar sancar closed this Feb 20, 2018
@sancar sancar deleted the sancar:fix/authenticationTimeout/maint3.x branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants