Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not break the text command loop on error #12481

Merged
merged 1 commit into from Mar 5, 2018
Merged

Do not break the text command loop on error #12481

merged 1 commit into from Mar 5, 2018

Conversation

jerrinot
Copy link
Contributor

@jerrinot jerrinot commented Mar 2, 2018 •
edited

Fixes #11722

This is consistent with runners for regular operations.

@jerrinot
Do not break the text command loop on error
746209e 
Fixes hazelcast#11721

This is consistent with runners for regular operations.
@jerrinot jerrinot added this to the 3.10 milestone Mar 2, 2018
@mmedenjak mmedenjak mentioned this pull request Mar 5, 2018
Closed
@hazelcast hazelcast deleted a comment from tkountis Mar 5, 2018
@hazelcast hazelcast deleted a comment from jerrinot Mar 5, 2018
@jerrinot
Copy link
Contributor Author

jerrinot commented Mar 5, 2018

@tkountis, @mmedenjak: thanks for your review!

@jerrinot jerrinot merged commit c4ee70d into hazelcast:master Mar 5, 2018
@jerrinot jerrinot deleted the fixes/rest-catching-throwable/master branch March 5, 2018 14:42
@jerrinot jerrinot mentioned this pull request Mar 5, 2018
Closed
@mmedenjak mmedenjak added the Source: Internal PR or issue was opened by an employee label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkountis tkountis tkountis approved these changes

@mmedenjak mmedenjak mmedenjak approved these changes

Assignees
No one assigned
Labels
Source: Internal PR or issue was opened by an employee Team: Core Type: Defect
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.

Exception in ResponseThreadRunnable causes REST API to fail
3 participants
@jerrinot @tkountis @mmedenjak