Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Observe contract of CacheEntryEvent#getValue for REMOVED/EXPIRED events #12507

Conversation

@vbekiaris
Copy link
Contributor

@vbekiaris vbekiaris commented Mar 6, 2018

When an entry event listener is registered with oldValueRequired==false
then both CacheEntryEvent#value and CacheEntryEvent#oldValue must be
null or equal to the value that was removed/expired.

(cherry picked from commit 025f468)

Backport of #12385

When an entry event listener is registered with oldValueRequired==false
then both CacheEntryEvent#value and CacheEntryEvent#oldValue must be
null or equal to the value that was removed/expired.

(cherry picked from commit 025f468)
@vbekiaris vbekiaris added this to the 3.9.4 milestone Mar 6, 2018
@vbekiaris vbekiaris self-assigned this Mar 6, 2018
@vbekiaris vbekiaris requested a review from kwart Mar 6, 2018
@vbekiaris
Copy link
Contributor Author

@vbekiaris vbekiaris commented Mar 6, 2018

Unrelated test failures:

com.hazelcast.client.map.ClientMapLoadAllTest.testGetMap_issue_3031:
test timed out after 60000 milliseconds

com.hazelcast.client.util.ClientStateListenerTest.testClientASYNCStartConnected:
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at com.hazelcast.client.util.ClientStateListenerTest.testClientASYNCStartConnected(ClientStateListenerTest.java:91)

https://hazelcast-l337.ci.cloudbees.com/job/new-lab-fast-pr/14126/

@vbekiaris
Copy link
Contributor Author

@vbekiaris vbekiaris commented Mar 6, 2018

run-lab-run

@kwart
kwart approved these changes Mar 6, 2018
@kwart kwart merged commit 37abe29 into hazelcast:maintenance-3.x Mar 6, 2018
1 check passed
1 check passed
default Test PASSed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.