Respect index config in query caches #12577
Conversation
Also adds javadoc about the non-atomicity of index updates. Fixes: #12358
| * if you need to observe the state when the map and its indexes are consistent | ||
| * about the state of a particular map entry, see | ||
| * {@link #addEntryListener(MapListener, boolean) addEntryListener} for more | ||
| * details.</li> |
ahmetmircik
Mar 13, 2018
Member
this explanation is valid for OBJECT and BINARY storage types i think. Is it also valid for NATIVE maps (since queries run on partition-threads)?
this explanation is valid for OBJECT and BINARY storage types i think. Is it also valid for NATIVE maps (since queries run on partition-threads)?
taburet
Mar 13, 2018
Author
Contributor
You are right, the javadoc is updated.
You are right, the javadoc is updated.
|
seems we can also backport this one. |
|
@ahmetmircik the backport PR is ready: #12580 |
| @Test | ||
| public void testIndexConfigIsRespected() { | ||
| final Config config = new Config(); | ||
| // @formatter:off |
vbekiaris
Mar 14, 2018
Contributor
IDE leftover?
IDE leftover?
taburet
Mar 14, 2018
Author
Contributor
That's intentional to make the config more easy to read. See Formatter Control section in Preferences -> Editor -> Code Style of IDEA.
That's intentional to make the config more easy to read. See Formatter Control section in Preferences -> Editor -> Code Style of IDEA.
vbekiaris
Mar 14, 2018
Contributor
I think we shouldn't have any IDE-specific directives in our codebase.
I think we shouldn't have any IDE-specific directives in our codebase.
taburet
Mar 14, 2018
•
Author
Contributor
It's a pretty widespread convention for turning the formatter off, Eclipse also supports this, but it's turned off by default in both IDEA and Eclipse. But you are right, until we have a consensus among all the team members on this feature, one shouldn't use it. Another topic for our future code style settings ;)
It's a pretty widespread convention for turning the formatter off, Eclipse also supports this, but it's turned off by default in both IDEA and Eclipse. But you are right, until we have a consensus among all the team members on this feature, one shouldn't use it. Another topic for our future code style settings ;)
Donnerbart
Mar 14, 2018
Contributor
I'm using the out-of-the-box formatter from IDEA and if I format that config snippet, it still looks like this. So I don't see why this is needed for IDEA.
After 3.10 is out I wanted to have a look at EditorConfig or something comparable, so we can define some of these formatting rules in a standard format in the project. For now I think we shouldn't start to add those specific ones shattered in the code.
I'm using the out-of-the-box formatter from IDEA and if I format that config snippet, it still looks like this. So I don't see why this is needed for IDEA.
After 3.10 is out I wanted to have a look at EditorConfig or something comparable, so we can define some of these formatting rules in a standard format in the project. For now I think we shouldn't start to add those specific ones shattered in the code.
Also moves the javadoc to QueryCache from IMap since IMap is not affected by the issue.
|
run-lab-run |
1 similar comment
|
run-lab-run |
Also adds javadoc about the non-atomicity of index updates.
Fixes: #12358