Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect index config in query caches #12577

Merged
merged 3 commits into from Mar 15, 2018
Merged

Conversation

@taburet
Copy link
Contributor

@taburet taburet commented Mar 13, 2018

Also adds javadoc about the non-atomicity of index updates.

Fixes: #12358

Also adds javadoc about the non-atomicity of index updates.

Fixes: #12358
@taburet taburet added this to the 3.10 milestone Mar 13, 2018
@taburet taburet self-assigned this Mar 13, 2018
@taburet taburet requested review from vbekiaris and ahmetmircik Mar 13, 2018
* if you need to observe the state when the map and its indexes are consistent
* about the state of a particular map entry, see
* {@link #addEntryListener(MapListener, boolean) addEntryListener} for more
* details.</li>

This comment has been minimized.

@ahmetmircik

ahmetmircik Mar 13, 2018
Member

this explanation is valid for OBJECT and BINARY storage types i think. Is it also valid for NATIVE maps (since queries run on partition-threads)?

This comment has been minimized.

@taburet

taburet Mar 13, 2018
Author Contributor

You are right, the javadoc is updated.

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Mar 13, 2018

seems we can also backport this one.

@taburet
Copy link
Contributor Author

@taburet taburet commented Mar 13, 2018

@ahmetmircik the backport PR is ready: #12580

@Test
public void testIndexConfigIsRespected() {
final Config config = new Config();
// @formatter:off

This comment has been minimized.

@vbekiaris

vbekiaris Mar 14, 2018
Contributor

IDE leftover?

This comment has been minimized.

@taburet

taburet Mar 14, 2018
Author Contributor

That's intentional to make the config more easy to read. See Formatter Control section in Preferences -> Editor -> Code Style of IDEA.

This comment has been minimized.

@vbekiaris

vbekiaris Mar 14, 2018
Contributor

I think we shouldn't have any IDE-specific directives in our codebase.

This comment has been minimized.

@taburet

taburet Mar 14, 2018
Author Contributor

It's a pretty widespread convention for turning the formatter off, Eclipse also supports this, but it's turned off by default in both IDEA and Eclipse. But you are right, until we have a consensus among all the team members on this feature, one shouldn't use it. Another topic for our future code style settings ;)

This comment has been minimized.

@Donnerbart

Donnerbart Mar 14, 2018
Contributor

I'm using the out-of-the-box formatter from IDEA and if I format that config snippet, it still looks like this. So I don't see why this is needed for IDEA.

After 3.10 is out I wanted to have a look at EditorConfig or something comparable, so we can define some of these formatting rules in a standard format in the project. For now I think we shouldn't start to add those specific ones shattered in the code.

Also moves the javadoc to QueryCache from IMap since IMap
is not affected by the issue.
@taburet
Copy link
Contributor Author

@taburet taburet commented Mar 15, 2018

run-lab-run

1 similar comment
@taburet
Copy link
Contributor Author

@taburet taburet commented Mar 15, 2018

run-lab-run

@taburet taburet merged commit 10800d7 into hazelcast:master Mar 15, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@taburet taburet deleted the taburet:fix/3.10/issue-12358 branch Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants