Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Pluggable configuration replacers #12809

Merged
merged 1 commit into from Apr 11, 2018

Conversation

@kwart
Copy link
Contributor

@kwart kwart commented Apr 9, 2018

Backport of #12798 to 3.9.x

As the XML schema for 3.9.x is fixed, the configuration of the Variable replacers differs in this backport.

Configuration

Only one replacer can be configured within Hazelcast properties by using a newly introduced property "hazelcast.config.replacer.class".
The fail-fast approach can be disabled by property "hazelcast.config.replacer.fail-if-value-missing". (Its controlled by a new attribute fail-if-value-missing in <config-replacers/> element in the upstream PR).
The init properties for the replacer are also configured as Hazelcast properties prefixed by replacer's fully qualified class name.

<hazelcast>
    <properties>
        <property name="hazelcast.config.replacer.class">com.acme.MyReplacer</property>
        <property name="hazelcast.config.replacer.fail-if-value-missing">false</property>
        <property name="com.acme.MyReplacer.myProperty">my value</property>
        <property name="com.acme.MyReplacer.anotherProperty">value</property>
        <!-- ... -->
    </properties>
    <!-- ... -->
</hazelcast>
@kwart kwart added this to the 3.9.4 milestone Apr 9, 2018
@kwart kwart self-assigned this Apr 9, 2018
@kwart kwart requested review from tkountis and blazember Apr 9, 2018
@kwart kwart force-pushed the kwart:config-replacers-3.9.x branch 2 times, most recently from 4009c18 to 48c91f7 Apr 9, 2018
@kwart kwart force-pushed the kwart:config-replacers-3.9.x branch from 7286214 to 6085ef5 Apr 11, 2018
…ensitive information in the configuration files for instance.
@kwart kwart force-pushed the kwart:config-replacers-3.9.x branch from 6085ef5 to e45cbb0 Apr 11, 2018
@kwart kwart merged commit b712bd9 into hazelcast:maintenance-3.x Apr 11, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@kwart kwart deleted the kwart:config-replacers-3.9.x branch Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.