Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connections to members after they are removed from cluster #12926

Merged
merged 1 commit into from Apr 19, 2018

Conversation

@mdogan
Copy link
Contributor

@mdogan mdogan commented Apr 19, 2018

When a member is suspected, its connection is closed immediately and if suspecting
member is the master, it removes that member from cluster.
But if a slave member receives a member remove event without suspecting that member,
its connection remains open, unless connection fails with an IO exception.

Additionally, Invocation now keeps reference to the connection which operation is sent
through. This is just for logging purposes. Before, Invocation was logging
the current/latest connection to the remote target.

3.10.1 backport of #12924

Fixes #12868

@mdogan mdogan added this to the 3.10.1 milestone Apr 19, 2018
When a member is suspected, its connection is closed immediately and if suspecting
member is the master, it removes that member from cluster.
But if a slave member receives a member remove event without suspecting that member,
its connection remains open, unless connection fails with an IO exception.

Additionally, `Invocation` now keeps reference to the connection which operation is sent
through. This is just for logging purposes. Before, `Invocation` was logging
the current/latest connection to the remote target.
@mdogan mdogan force-pushed the mdogan:member-remove-conn-close-x branch from 135e971 to 98499f9 Apr 19, 2018
@mdogan mdogan merged commit 7a4db33 into hazelcast:maintenance-3.x Apr 19, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@mdogan mdogan deleted the mdogan:member-remove-conn-close-x branch Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.