Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed close problems in NioOutboundPipeline #13363

Conversation

@pveentjer
Copy link
Member

@pveentjer pveentjer commented Jun 26, 2018

There are 2 problems:

  • tmp stall because a task is executed on the io thread from
    that same io thread and then the io thread waits for it. Because
    the thread will not execute its own task (yet) you have a 3s stall
    in the io pipeline. This is a big problem because is blocks all traffic
    for that io thread.

  • the close task is scheduled as a 'packet'. If the pipeline already is
    scheduled, scheduling the close task will not get picked up as part
    of an optimization.

This pr fixes the above problems.

@pveentjer pveentjer added this to the 3.10.3 milestone Jun 26, 2018
There are 2 problems:
* tmp stall because a task is execute on the io thread from
  that same io thread and then the io thread waits for it. Because
  the thread will not execute its own task (yet) you have a 3s stall
  in the io pipeline. This is a big problem because is blocks all traffic
  for that io thread.

* the close task is scheduled as a 'packet'. If the pipeline already is
  scheduled, scheduling the close task will not get picked up as part
  of an optimization.

This pr fixes the above problems.
@pveentjer pveentjer force-pushed the pveentjer:v3.10/fix/NioOutboundPipeline-close branch from d6b488a to a906dda Jun 26, 2018
@tkountis tkountis self-requested a review Jun 26, 2018
@pveentjer pveentjer merged commit d3caf82 into hazelcast:maintenance-3.x Jun 28, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@pveentjer pveentjer deleted the pveentjer:v3.10/fix/NioOutboundPipeline-close branch Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.