Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT]Added storage destroy to release HD resources. #13659

Merged

Conversation

@ahmetmircik
Copy link
Member

@ahmetmircik ahmetmircik commented Aug 29, 2018

To release key+value pairs storage#clear should be called,
storage#destroy only releases internal resources of backing
data structure

closes hazelcast/hazelcast-enterprise#859

@ahmetmircik ahmetmircik added this to the 3.10.5 milestone Aug 29, 2018
@ahmetmircik ahmetmircik changed the title [WIP BACKPORT]Added storage destroy to release HD resources. [BACKPORT]Added storage destroy to release HD resources. Aug 29, 2018
@ahmetmircik ahmetmircik requested review from mmedenjak and taburet Aug 29, 2018
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.10.5/hdLeakTest branch from 88abbb7 to 06eba0b Aug 29, 2018
@mmedenjak mmedenjak modified the milestones: 3.10.5, 3.10.6 Sep 3, 2018
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.10.5/hdLeakTest branch from 06eba0b to a1a7c16 Sep 11, 2018
To release key+value pairs storage#clear should be called
besides storage#destroy because it only releases internal
resources of backing data structure not key+value pairs
@ahmetmircik ahmetmircik merged commit 9594c23 into hazelcast:maintenance-3.x Sep 11, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/3.10.5/hdLeakTest branch Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.