Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont keep the endpoint reference to clean client resources #13755

Conversation

@sancar
Copy link
Member

@sancar sancar commented Sep 13, 2018

We are scheduling a task to clean client resources after some
time(60 seconds). Eventough endpoint is removed, we were keeping
a reference to it via this task. This was causing unncessary leak
for 60 seconds since the endpoint keeps reference to heavy objects
like connection.

With this pr, we are passing only necessary fields objects of
client endpoint to task to avoid keeping reference to the client
endpoint itself.

(cherry picked from commit e3632c6)

We are scheduling a task to clean client resources after some
time(60 seconds). Eventough endpoint is removed, we were keeping
a reference to it via this task. This was causing unncessary leak
for 60 seconds since the endpoint keeps reference to heavy objects
like `connection`.

With this pr, we are passing only necessary fields objects of
client endpoint to task to avoid keeping reference to the client
endpoint itself.

(cherry picked from commit e3632c6)
@sancar sancar added this to the 3.10.6 milestone Sep 13, 2018
@sancar sancar self-assigned this Sep 13, 2018
@sancar sancar merged commit 8400dd0 into hazelcast:maintenance-3.x Sep 13, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/letEndpointReferenceGoWhenClientDisconnected/maint3.x branch Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.