Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Forward map value extractors to HD indexes #13775

Merged

Conversation

@pveentjer
Copy link
Member

@pveentjer pveentjer commented Sep 17, 2018

This change fixes two issues:

  1. The consistency issue: queryable entries returned by HD indexes were
    unaware of the map value extractors, so it was impossible to extract
    values provided by the extractors from the returned entries.

  2. The performance issue: Extractors.empty is a pretty expensive call
    and it was performed for every returned entry. According to a slightly
    modified version of HDIndexPerfTest the throughput is about 2 times
    higher now.

Fixes: hazelcast/hazelcast-enterprise#2109

Backport of: #13692
For enterprise part see: hazelcast/hazelcast-enterprise#2421

This change fixes two issues:

1. The consistency issue: queryable entries returned by HD indexes were
unaware of the map value extractors, so it was impossible to extract
values provided by the extractors from the returned entries.

2. The performance issue: Extractors.empty is a pretty expensive call
and it was performed for every returned entry. According to a slightly
modified version of HDIndexPerfTest the throughput is about 2 times
higher now.

Fixes: hazelcast/hazelcast-enterprise#2109
@pveentjer pveentjer force-pushed the pveentjer:v3.10/fix/ee-issue-2109 branch from b8ce85a to 61c69be Sep 17, 2018
@jbee
jbee approved these changes Sep 17, 2018
@pveentjer pveentjer merged commit 9b4e978 into hazelcast:maintenance-3.x Sep 17, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@pveentjer pveentjer deleted the pveentjer:v3.10/fix/ee-issue-2109 branch Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.