Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SerializationException propagated to client when response unserializable #13777

Conversation

@sancar
Copy link
Member

@sancar sancar commented Sep 17, 2018

When an unserializableResponse is trying to be send to client as response
from executor service tasks, the exception was logged on the server side,
and there was no response returned back to the client.

This pr, removes the logging in such case and sends related expcetion,
(HazelcastSerializationException) to the client.

Similar behaviour is also tested for the core side and verified it
already works as expected.

fixes #13639

(cherry picked from commit 8fbdc58)

@sancar sancar added this to the 3.10.6 milestone Sep 17, 2018
@sancar sancar self-assigned this Sep 17, 2018
@sancar sancar force-pushed the sancar:fix/unserializableResponseToClient/maint3.x branch 2 times, most recently from 8db66a5 to 6974725 Sep 17, 2018
When an unserializableResponse is trying to be send to client as response
from executor service tasks, the exception was logged on the server side,
and there was no response returned back to the client.

This pr, removes the logging in such case and sends related expcetion,
(HazelcastSerializationException) to the client.

Similar behaviour is also tested for the core side and verified it
already works as expected.

fixes #13639

(cherry picked from commit 8fbdc58)
@sancar sancar force-pushed the sancar:fix/unserializableResponseToClient/maint3.x branch from 6974725 to 53cebdb Sep 17, 2018
@sancar sancar merged commit dfe928b into hazelcast:maintenance-3.x Sep 17, 2018
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/unserializableResponseToClient/maint3.x branch Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.