Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded iterations and object creations during client messag… #13784

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Sep 18, 2018

…e convertion to user object

fix candidate for: #13590

I did some quick simulator runs(1 client-1 server) seems we may have some gains compared to master. These are the results.

  • Tests only doing size check of returning sets from keySet and entrySet methods.

keySet:

keyCount master fix increase
100 38,906.68 ops/s 45,077.51 ops/s 18%
1_000 16,703.54 ops/s 24,531.73 ops/s 50%
100_000 40.18 ops/s 200.85 ops/s 400%

entrySet:

entryCount master fix increase
100 39,953.71 ops/s 42,463.02 ops/s nearly-same
1_000 15,911.12 ops/s 20,403.84 ops/s 33%
100_000 23.13 ops/s 155.39 ops/s 500%
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.11/clientBulkResponseHandling branch from 1598ffd to 9e75a66 Sep 18, 2018
@mmedenjak mmedenjak added this to the 3.12 milestone Sep 18, 2018
@pveentjer

This comment has been minimized.

Copy link
Member

pveentjer commented Sep 18, 2018

Good work @ahmetmircik

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.11/clientBulkResponseHandling branch from 9e75a66 to aba05f7 Sep 18, 2018
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.11/clientBulkResponseHandling branch from aba05f7 to fdbecfb Oct 2, 2018
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.11/clientBulkResponseHandling branch from fdbecfb to d4af752 Oct 10, 2018
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/3.11/clientBulkResponseHandling branch from d4af752 to e5f82e9 Nov 1, 2018
wip
@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Mar 20, 2019

Moving to a later release based on the comment here.

@mmedenjak mmedenjak removed this from the 3.12 milestone Mar 20, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.