Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove password from the default Hazelcast configuration #14603

Merged

Conversation

@kwart
Copy link
Member

@kwart kwart commented Feb 28, 2019

Fixes #14260.

As the default Hazelcast configuration doesn't use Group password, we can remove it.

This PR also improves the non-empty password INFO message. It's newly only logged when all the following conditions are met:

  • security is disabled
  • password is not empty
  • password is not the Hazelcast default one
@kwart kwart added this to the 3.12 milestone Feb 28, 2019
@kwart kwart self-assigned this Feb 28, 2019
@kwart kwart requested review from vbekiaris and blazember Feb 28, 2019
@@ -69,8 +69,9 @@ hazelcast:
secretKeyFactoryAlgorithm: PBKDF2WithHmacSHA1
#
# Specifies the name and password for a cluster group you create.
# Cluster groups allow you to create separate sub-clusters within your Hazelcast cluster to
# create a simple security. They are also referenced in the WAN Replication configuration.
# Cluster groups allow you to create separate sub-clusters s with different names.
Copy link
Contributor

@Holmistr Holmistr Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a typo with the extra 's' in "...sub-clusters s with..."

Loading

Copy link
Member Author

@kwart kwart Feb 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ;). Thanks. I will fix it.

Loading

…rning only if a non-default & non-empty password is used and the Hazelcast security is disabled.
@kwart kwart force-pushed the 14260-remove-password-from-default-config branch from 367697c to ffeb269 Feb 28, 2019
@kwart kwart merged commit 8b93dae into hazelcast:master Mar 1, 2019
1 check passed
Loading
@kwart kwart deleted the 14260-remove-password-from-default-config branch Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants