Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix socket channel leak when networking is restarted after cluster merge #14699

Merged

Conversation

Projects
None yet
3 participants
@mdogan
Copy link
Member

commented Mar 14, 2019

Networking service is stopped and restarted during cluster merge.
But socket channel's closeListenerExecutor is not restarted even
though it's stopped during shutdown. That's why ChannelCloseListener
is not called and some resources leak, including channels set.

Additionally, PublishAllTask is re-scheduled each time networking
is started (when metrics is enabled). After each cluster merge,
there'll be an additional PublishAllTask is scheduled.

Fixes hazelcast/hazelcast-enterprise#2689

Backport of #14698

Fix socket channel leak when networking is restarted after cluster merge
Networking service is stopped and restarted during cluster merge.
But socket channel's `closeListenerExecutor` is not restarted even
though it's stopped during shutdown. That's why `ChannelCloseListener`
is not called and some resources leak, including `channels` set.

Additionally, `PublishAllTask` is re-scheduled each time networking
is started (when metrics is enabled). After each cluster merge,
there'll be an additional `PublishAllTask` is scheduled.

@mdogan mdogan added this to the 3.11.3 milestone Mar 14, 2019

@mmedenjak mmedenjak requested review from pveentjer and removed request for pveentjer Mar 14, 2019

@hazelcast hazelcast deleted a comment from mdogan Mar 14, 2019

@mmedenjak mmedenjak merged commit b4ee73a into hazelcast:maintenance-3.x Mar 14, 2019

1 check passed

default Test PASSed.
Details

@mdogan mdogan deleted the mdogan:networking-channel-leak-x branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.