Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes operation stats for some map methods #14726

Conversation

Projects
None yet
3 participants
@mustafaiman
Copy link
Member

commented Mar 20, 2019

Some operation stats incorrectly reported operations per partition. Now all operation stats are converted to report number per user call.

Ground work for hazelcast/hazelcast-enterprise#2704

@@ -48,4 +52,14 @@ protected void extractAndAppendResult(Collection<QueryResultRow> results, QueryR
results.addAll(queryResult.getRows());
}

protected void incrementOperationStat() {

This comment has been minimized.

Copy link
@ahmetmircik

ahmetmircik Mar 21, 2019

Member

to obey DRY principle, maybe we can use this method for all message tasks by extracting it to a utility class.

@ahmetmircik
Copy link
Member

left a comment

minor comment + looks good.

Fixes operation stats for some map methods
Some operation stats incorrectly reported operations per partition. Now all operation stats are converted to report number per user call.

@mustafaiman mustafaiman force-pushed the mustafaiman:backport/fix/map-stats-multiple-update branch from 6c222cf to 1fb1d68 Mar 21, 2019

@mustafaiman

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

@ahmetmircik moved the utility method to newly created LocalMapStatsUtil.

@mustafaiman

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2019

thanks for the reviews @ahmetmircik @tkountis

@mustafaiman mustafaiman merged commit c88193f into hazelcast:maintenance-3.x Mar 25, 2019

1 check passed

default Test PASSed.
Details

@mustafaiman mustafaiman deleted the mustafaiman:backport/fix/map-stats-multiple-update branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.