Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable migrations while mastership claim is in progress #14745

Merged

Conversation

Projects
None yet
2 participants
@mdogan
Copy link
Member

commented Mar 22, 2019

Otherwise, when master candidate, the member claiming the mastership,
starts to shutdown, it can create & submit migrations before its claim
is approved by all final cluster members.
This can break safety when claim is partially accepted
by some of the members and they process the migration operations.

Backport of #14744

Disable migrations while mastership claim is in progress
Otherwise, when master candidate, the member claiming the mastership,
starts to shutdown, it can create & submit migrations before its claim
is approved by all final cluster members.
This can break safety when claim is partially accepted
by some of the members and they process the migration operations.

@mdogan mdogan merged commit c2cd1d4 into hazelcast:maintenance-3.x Mar 25, 2019

1 check passed

default Test PASSed.
Details

@mdogan mdogan deleted the mdogan:mastership-claim-shutdown-x branch Mar 25, 2019

mdogan added a commit to mdogan/hazelcast that referenced this pull request Mar 29, 2019

Ensure migrations resumed during cluster merge
One of the members on merging side can start mastership claim
while merging to another cluster after master leaves.
But `DecideNewMembersViewTask` can fail because mastership claiming
member also starts the merge process, it resets all internal state.

After merge, migration-allowed flag should be set back
if it's disabled during mastership claim.

Also `MigrationManager` should reset `migrationTasksAllowed` flag
when `reset()` is called.

This bug was introduced by: hazelcast#14745

Holmistr added a commit that referenced this pull request Apr 1, 2019

Ensure migrations resumed during cluster merge
One of the members on merging side can start mastership claim
while merging to another cluster after master leaves.
But `DecideNewMembersViewTask` can fail because mastership claiming
member also starts the merge process, it resets all internal state.

After merge, migration-allowed flag should be set back
if it's disabled during mastership claim.

Also `MigrationManager` should reset `migrationTasksAllowed` flag
when `reset()` is called.

This bug was introduced by: #14745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.