Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply partition response coming from old connection #14793

Merged

Conversation

Projects
None yet
3 participants
@sancar
Copy link
Member

commented Mar 28, 2019

#14730
In the fix below, we changed the fetching partitions so that we get
from owner connection only. This fix checks the connection that response
comes from to see if should be applied or not. If connection is
changed, response should not be applied in order not to mess with
partition state.
We saw the problem in following issue:
related to hazelcast/hazelcast-enterprise#2854

(cherry picked from commit c0cd001)

Backport of #14792

@sancar sancar added this to the 3.11.3 milestone Mar 28, 2019

@sancar sancar self-assigned this Mar 28, 2019

@sancar sancar changed the title Don't apply response coming from old connection Don't apply partition response coming from old connection Mar 28, 2019

@mdogan

mdogan approved these changes Mar 28, 2019

@sancar

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

run-lab-run

Don't apply response coming from old connection
#14730
In the fix below, we changed the fetching partitions so that we get
from owner connection only. This fix checks the connection that response
comes from to see if should be applied or not. If connection is
changed, response should not be applied in order not to mess with
partition state.
We saw the problem in following issue:
related to hazelcast/hazelcast-enterprise#2854

(cherry picked from commit c0cd001)

@sancar sancar force-pushed the sancar:fix/oldPartitionResponse/maint3.x branch from 18060c7 to d3a9c57 Mar 29, 2019

@sancar sancar merged commit 2054420 into hazelcast:maintenance-3.x Mar 29, 2019

1 check passed

default Test PASSed.
Details

@sancar sancar deleted the sancar:fix/oldPartitionResponse/maint3.x branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.