Commits on Apr 4, 2019

1. Prevent migration operations running before previous finalization com… …

   …pletes
   
   Normally finalization is scheduled when either `PublishCompletedMigrationsOperation`
   or a migration operation is executed.
   
   But in a small window of time, a `MigrationOperation` can come and start just
   after `PublishCompletedMigrationsOperation` starts executing.
   
   In this case, if completed migrations include a previous migration which
   belongs to the same partition with `MigrationOperation` and local member
   was source of that migration and if `MigrationOperation` starts its execution
   before the `FinalizeMigrationOperation` is put into the partition operation
   threads queue, then `FinalizeMigrationOperation` can run after the `MigrationOperation`
   and remove data replicated by it.
   
   To fix that, `MigrationOperation` is retried if it cannot set `migrating` flag
   of a partition. `migrating` flag is set by migration operations and cleared by
   `FinalizeMigrationOperation`. So, if `migrating` flag is set while `MigrationOperation`
   is executed, that means former `FinalizeMigrationOperation` is not executed yet.
   
   (cherry picked from commit 5060616)

   

   mdogan committed Apr 4, 2019
   Copy the full SHA

   3969c8d View commit details

   Browse the repository at this point in the history