Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricsRegistry unregister fix. #14837

Conversation

Projects
None yet
2 participants
@mmedenjak
Copy link
Contributor

commented Apr 3, 2019

NioNetworking can be stopped and started. When this happens, the
IOThreads get re-registered and will overwrite the old probes. This
causes logging noise.

This PR fixes this problem by deregistering the IOThreads when NioNetworking
is shutdown.

(cherry picked from commit 4d9c28e)

1:1 backport of #14823

MetricsRegistry unregister fix.
NioNetworking can be stopped and started. When this happens, the
IOThreads get re-registered and will overwrite the old probes. This
causes logging noise.

This PR fixes this problem by deregistering the IOThreads when NioNetworking
is shutdown.

(cherry picked from commit 4d9c28e)

@mmedenjak mmedenjak self-assigned this Apr 3, 2019

@mmedenjak mmedenjak added this to the 3.12.1 milestone Apr 3, 2019

@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Merging as a clean cherry-pick with 1 approval - mine.

@mmedenjak mmedenjak merged commit 7a20c66 into hazelcast:maintenance-3.x Apr 4, 2019

1 check passed

default Test PASSed.
Details

@mmedenjak mmedenjak deleted the mmedenjak:v3.12/fix/NioNetworking-overwriting-probes-restart-backport branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.