Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Client handle restarted members with same uuid different address #14842

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@sancar
Copy link
Member

sancar commented Apr 5, 2019

In hotrestart feature, members will preserve their uuid's, but can
start with different addresses. Client was relying on only uuid,
and when a member restarted, it was assuming nothing has changed.
When it does not change its local membership view in this case, it
is trying to continue with old address which is wrong.

Also for these cases, we were not firing any member
removed,added events. With this fix, for a restarted member
with different address we will wire removed,added events.

Note that, if member comes back with same address and uuid, from
client point of view there is no way to detect the restart. So
no events will be fired in that case.

fixes #14839

In hotrestart feature, members will preserve their uuid's, but can
start with different addresses. Client was relying on only uuid,
and when a member restarted, it was assuming nothing has changed.
When it does not change its local membership view in this case, it
is trying to continue with old address which is wrong.

Also for these cases, we were not firing any member
removed,added events. With this fix, for a restarted member
with different address we will wire removed,added events.

Note that, if member comes back with same address and uuid, from
client point of view there is no way to detect the restart. So
no events will be fired in that case.

fixes #14839
@sancar sancar self-assigned this Apr 5, 2019
@sancar sancar requested review from asimarslan and ihsandemir Apr 5, 2019
@sancar sancar merged commit d055605 into hazelcast:master Apr 5, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@sancar sancar deleted the sancar:fix/hotRestartMembership/master branch Apr 5, 2019
@mmedenjak mmedenjak added this to the 4.0 milestone Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.