Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish only expired events in case of eviction #14954

Merged

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Apr 29, 2019

For 3.x series, we were firing both expired and evicted events when an evicted entry
is also expired. The reason for this was to keep backward compatible behavior.

closes #14712

@ahmetmircik ahmetmircik added this to the 4.0 milestone Apr 29, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/oneOfEvictOrExpired branch 2 times, most recently from e3569d5 to 336d5f7 May 27, 2019
latch.countDown();
}
}, false);
map.addEntryListener((EntryExpiredListener<Integer, Integer>) event -> latch.countDown(), false);

This comment has been minimized.

Copy link
@galibey

galibey May 31, 2019

Contributor

Minor thing but maybe we should rename test names as well. testMapRecordEviction() -> testMapRecordExpiration() and testIssue1085ExpirationBackup().

Copy link
Contributor

galibey left a comment

Looks good 👍 . Just a single minor comment.

@@ -18,6 +18,7 @@

import com.hazelcast.client.impl.protocol.ClientMessage;
import com.hazelcast.client.impl.protocol.codec.ReplicatedMapAddEntryListenerCodec;
import com.hazelcast.core.EntryEvent;

This comment has been minimized.

Copy link
@mmedenjak

mmedenjak Jun 4, 2019

Contributor

Unused

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/oneOfEvictOrExpired branch 6 times, most recently from 6688b08 to bc6f58f Jun 11, 2019
For 3.x series, we were firing both expired and evicted events when an evicted entry
is also expired at the same time. The reason for this was to keep backward compatible behavior.
Now we don't need to keep this compatible behavior with 4.0
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/oneOfEvictOrExpired branch from e966329 to 4be4367 Jun 12, 2019
@ahmetmircik ahmetmircik merged commit d75bdde into hazelcast:master Jun 12, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/oneOfEvictOrExpired branch Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.