Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return result of interceptor remove call #14955

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Apr 29, 2019

closes #9430

  • (Add|Remove)InterceptorOperation extends MapOperation, this is to reduce code duplication.
  • IMap#removeInterceptor returns true|false
@ahmetmircik ahmetmircik added this to the 4.0 milestone Apr 29, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch from edbebae to 2ae30d4 Apr 29, 2019
@mmedenjak mmedenjak added the Team: Core label May 2, 2019
@mustafaiman

This comment has been minimized.

Copy link
Contributor

mustafaiman commented May 2, 2019

There is no test verifying the return value

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch from 2ae30d4 to f848851 May 3, 2019
@ahmetmircik

This comment has been minimized.

Copy link
Member Author

ahmetmircik commented May 3, 2019

thanks @mustafaiman, i added client&server tests.

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch 3 times, most recently from e196760 to 50b2301 May 21, 2019
Copy link
Contributor

galibey left a comment

LGTM 👍

@mmedenjak

This comment has been minimized.

Copy link
Contributor

mmedenjak commented Jun 4, 2019

@ahmetmircik can you rebase and merge it?

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch from 50b2301 to 34acaa3 Jun 11, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch from 34acaa3 to 5774d48 Jun 11, 2019
@ahmetmircik ahmetmircik merged commit 368abfe into hazelcast:master Jun 11, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/returnResultOfRemoveInterceptor branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.