Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Client authentication to blockingExecutor #14956

Merged
merged 2 commits into from May 14, 2019
Merged

Conversation

@kwart
Copy link
Contributor

kwart commented Apr 29, 2019

Upstream PR for #14941.

@kwart kwart added the Type: Defect label Apr 29, 2019
@kwart kwart added this to the 4.0 milestone Apr 29, 2019
@kwart kwart requested a review from sancar Apr 29, 2019
@kwart kwart self-assigned this Apr 29, 2019
@sancar sancar requested a review from asimarslan Apr 29, 2019
@sancar

This comment has been minimized.

Copy link
Member

sancar commented Apr 29, 2019

The question here is, are we ok with the authentication is not prioritized over other blocking tasks?
There was no such problem in 3.11 because there are no other BlockingMessageTasks there.

For reference, this is the pr that we marked them as urgent. #8561

@sancar sancar added the Team: Client label Apr 29, 2019
@kwart

This comment has been minimized.

Copy link
Contributor Author

kwart commented Apr 29, 2019

To me it looks safe enough:

  • only client authentication is affected
  • the change allows more concurrent client authentications by default

@pveentjer Do you have any objection?

…cation messages. They will not block.
@sancar
sancar approved these changes May 14, 2019
@kwart kwart requested review from vbekiaris and removed request for asimarslan May 14, 2019
@kwart kwart merged commit f0471f6 into hazelcast:master May 14, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@kwart kwart deleted the kwart:unblockAuthn branch May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.