Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backward compatible ADDED event from loadAll. #14964

Merged

Conversation

@ahmetmircik
Copy link
Member

ahmetmircik commented Apr 30, 2019

addressed #13501 (comment)

public void receiveAddedEventsWhenLoadAll() throws Exception {
testLoadAll(ADDED);
}

private void testLoadAll(EventType expectedEventType) throws Exception {

This comment has been minimized.

Copy link
@blazember

blazember May 7, 2019

Contributor

Think this method is not needed anymore and it's content can be moved into receiveLoadedEventsWhenLoadAll().

This comment has been minimized.

Copy link
@ahmetmircik

ahmetmircik May 7, 2019

Author Member

done.

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/loadAllPublishesLoadedEvent branch from fc72a94 to cf89eb8 May 7, 2019
@@ -73,7 +72,6 @@
private int partitionId;
private TruePredicate<EJ_TYPE> TRUE_PREDICATE = new TruePredicate<EJ_TYPE>();
private Function<EJ_TYPE, EJ_TYPE> IDENTITY_FUNCTION = new IdentityFunction<EJ_TYPE>();
private boolean loadAllPublishesAdded = false;

private void init() {

This comment has been minimized.

Copy link
@blazember

blazember May 7, 2019

Contributor

We can add the @Before annotation back here and remove the init() calls from the test cases. I introduced explicit init() calls only to make the load behavior parameterized by test case, see https://github.com/hazelcast/hazelcast/pull/13674/files#r214365582.

This comment has been minimized.

Copy link
@ahmetmircik

ahmetmircik May 8, 2019

Author Member

lately seen this one, also addressed it.

Copy link
Contributor

blazember left a comment

Lfet one minor, but LGTM.

@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/loadAllPublishesLoadedEvent branch from cf89eb8 to 0fcb7c0 May 8, 2019
@ahmetmircik ahmetmircik force-pushed the ahmetmircik:fix/4.0/loadAllPublishesLoadedEvent branch from 0fcb7c0 to 6f90343 May 24, 2019
@ahmetmircik ahmetmircik merged commit 4622792 into hazelcast:master May 24, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@ahmetmircik ahmetmircik deleted the ahmetmircik:fix/4.0/loadAllPublishesLoadedEvent branch May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.