Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deserialization when merging entries received via WAN #14982

Merged

Conversation

@mmedenjak
Copy link
Contributor

mmedenjak commented May 6, 2019

Even with hazelcast.wan.map.useDeleteWhenProcessingRemoveEvents set to
true, the key would unconditionally be deserialized. This not only
introduces a overhead in the case when using built-in merge policies but
also fails when the class is not present in the target cluster,
rendering WAN replication unusable. Fixed by using lazy deserialization.

EE (contains test): hazelcast/hazelcast-enterprise#2951

Even with hazelcast.wan.map.useDeleteWhenProcessingRemoveEvents set to
true, the key would unconditionally be deserialized. This not only
introduces a overhead in the case when using built-in merge policies but
also fails when the class is not present in the target cluster,
rendering WAN replication unusable. Fixed by using lazy deserialization.
@mmedenjak mmedenjak added this to the 4.0 milestone May 6, 2019
@mmedenjak mmedenjak self-assigned this May 6, 2019
@mmedenjak mmedenjak requested review from blazember and petrpleshachkov and removed request for petrpleshachkov Jun 4, 2019
@petrpleshachkov petrpleshachkov self-requested a review Jun 4, 2019
@mmedenjak mmedenjak merged commit 03e4f43 into hazelcast:master Jun 11, 2019
1 check passed
1 check passed
default Test PASSed.
Details
@mmedenjak mmedenjak deleted the mmedenjak:4.0-wan-merge-avoid-deserialisation branch Jun 11, 2019
@mmedenjak

This comment has been minimized.

Copy link
Contributor Author

mmedenjak commented Jun 11, 2019

Thank you for the reviews @blazember @petrpleshachkov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.